Skip to content

Human-readable metadata scan - #6519

Open
ArbaazKhan1 wants to merge 2 commits into
apache:mainfrom
ArbaazKhan1:accumulo-3772
Open

Human-readable metadata scan #6519
ArbaazKhan1 wants to merge 2 commits into
apache:mainfrom
ArbaazKhan1:accumulo-3772

Conversation

@ArbaazKhan1

Copy link
Copy Markdown
Contributor

Closes issue #3772

  • Updated StoredTabletFile.toString to use toMinimalString() making tablet file ranges readable in logs and other outputs.
  • Updated ScanCommand to decode file and scan column qualifiers when scanning metadata tables
  • cleaned up FileMetadataUtil loggin to use SLF4J placeholders

Comment thread test/src/main/java/org/apache/accumulo/test/util/FileMetadataUtil.java Outdated
executionHintsOpt = new Option(null, "execution-hints", true, "Execution hints map");
scanServerOpt =
new Option("cl", "consistency-level", true, "set consistency level (experimental)");
decodeMetadataOpt = new Option("dm", "decode-metadata", false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we need an option. If the user has the ability to scan the metadata, then we should just show them the un-obfuscated metadata entry.

@phrocker phrocker Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't accumulo already have formatters? metadataformatter that extends default formatter could be a better option and obviate the need for an option. also could be default?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but I think the intention is to remove formatters. See #3265.

@phrocker phrocker Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you. I encountered this last year sometime when testing 4.0, but I have a very poor memory....

Should this option be flipped? On by default, old method an option just in case someone relies on the encoded form?

I think it's pretty fair to say 4.0 changes the output, though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal was to avoid changing the normal metadata scan output in a way that might make users think that the decoded form is the actual stored metadata representation. I figured adding a new option, allows for the default behavior to remain unchanged, and users only get the decoded/human-readable form when they explicitly ask for it

Comment thread core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No chop merge see files ranges in metadata scan

3 participants